DO proxy the WMS tiles, to prevent mixing secure/insecure content #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could put a big burden on ckan and the web server (specially combined with #16). I think that it could make sense as an optional configuration. Check the note regarding config options at the end of this section if you want to go down that route: |
|
You're right. I'll add it to the config instead. |
This PR is 7 years old and according to this comment it is superseded by a config. It also has conflicts, it can probably be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose proxying WMS tiles, to prevent mixing secure/insecure content. Maybe in the long term it should be configurable?